Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update writer to buffer by payload size instead of by trace count #499

Merged
merged 1 commit into from
Mar 21, 2019
Merged

update writer to buffer by payload size instead of by trace count #499

merged 1 commit into from
Mar 21, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Mar 20, 2019

This PR updates the writer to buffer by payload size instead of by trace count to avoid reaching the agent payload limit.

@rochdev rochdev added enhancement New feature or request core labels Mar 20, 2019
@rochdev rochdev added this to the 0.11.0 milestone Mar 20, 2019
brettlangdon
brettlangdon approved these changes Mar 21, 2019
View reviewed changes
src/writer.js Show resolved Hide resolved
src/writer.js Show resolved Hide resolved
@rochdev rochdev merged commit 7f3c2a4 into v0.11.0 Mar 21, 2019
@rochdev rochdev deleted the buffer-by-size branch March 21, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
core enhancement New feature or request
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rochdev @brettlangdon