Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix query string being included in the http.url tag #531

Merged
merged 1 commit into from
Apr 10, 2019
Merged

fix query string being included in the http.url tag #531

merged 1 commit into from
Apr 10, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Apr 9, 2019

This PR removes the query string from the http.url tag since it can include sensitive data. The query string will be added as a configurable tag in a future version.

@rochdev rochdev added bug Something isn't working integrations labels Apr 9, 2019
@rochdev rochdev added this to the 0.10.4 milestone Apr 9, 2019
brettlangdon
brettlangdon approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rochdev rochdev merged commit db6a9ab into master Apr 10, 2019
@rochdev rochdev deleted the fix-query-string-in-url branch April 10, 2019 14:28
@bsamsom bsamsom mentioned this pull request May 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working integrations
Projects
None yet
Milestone
0.10.4
Development

Successfully merging this pull request may close these issues.
2 participants
@rochdev @brettlangdon