Add typings for ext submodules #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would say to narrow the values similar to OpenTracing. Then it will be possible as a future improvement to also add auto completion for any built-in tag by defining accepted values. |
rochdev
requested changes
Apr 24, 2019
|
Added the changes as a separate commit for clarity, you can squash it if you agree with the changes. |
rochdev
previously approved these changes
May 1, 2019
There was a problem hiding this comment.
LGTM
@Oblosys Do you think these should be tested in test.ts? Maybe at least one entry per file just to validate they are picked up by the transpiler? Is it guaranteed that TypeScript will always pick up every .d.ts for a corresponding .js?
|
Ah, there are tests, but they are in the |
rochdev
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed some of these typings, so I created the others as well. The Datadog constants are typed as
string, to avoid duplicating the values in the type definitions, but the constants fromopentracingare imported, so their types are narrowed to the actual values. In case you want this to be consistent, those constants could be typed as string as well (or the Datadog constants could be narrowed to their actual values).