update supported engines to be less strict #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the supported engines to be less strict.
Originally, the engines were made more strict because of potential issues with old versions of Node that have bugs which may impact the tracer. However, there are similar issues with versions above the currently supported engines, so this proved to be less predictable that expected.
Instead of bumping the version number constantly as we find new bugs in Node, we should instead loosen the range to support the entire range of the major versions we support.
If any user hits one of the issues we were trying to avoid, we can recommend they update Node and/or we can investigate a way to work around the issue.