Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues with event listeners in the
net
plugin:close
andtimeout
events were not handled. This could cause a memory leak if the socket was destroyed or timed out since the span would never be finished.Since the
lookup
event cannot be reliably associated with the correct span whenconnect()
is called multiple times, thetcp.remote.address
tag was moved to thedns
plugin instead as a newdns.address
tag.