Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for promise #570

Merged
merged 1 commit into from
May 21, 2019
Merged

add support for promise #570

merged 1 commit into from
May 21, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented May 17, 2019

This PR adds support for the promise module to ensure callbacks to then() are bound to the correct scope.

@rochdev rochdev added enhancement New feature or request integrations labels May 17, 2019
@rochdev rochdev added this to the 0.12.0 milestone May 17, 2019
@rochdev rochdev requested a review from rishabh May 17, 2019 18:35
@rochdev rochdev merged commit 50770c2 into v0.12.0 May 21, 2019
@rochdev rochdev deleted the promise-plugin branch May 21, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh rishabh rishabh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request integrations
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rochdev @rishabh