update analytics config with a simpler API that also fixes plugin config #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
added
bug
rishabh
reviewed
May 28, 2019
| @@ -92,8 +92,6 @@ const web = { | |||
| [RESOURCE_NAME]: middleware._name || middleware.name || '<anonymous>' | |||
| }) | |||
|
|
|||
| analyticsSampler.sample(span, req._datadog.config.analytics) | |||
There was a problem hiding this comment.
Why are we not sampling this anymore?
There was a problem hiding this comment.
Without the per span name configuration this would never be sampled, so it was simply removed.
rishabh
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Trace Analytics client configuration with a simpler API which no longer supports configuring individual operations. The previous API was confusing, difficult to use and had issues caused by its unnecessary complexity. We will revisit operation level configuration later with a more idiomatic API.