Add tedious integration #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
requested changes
Jun 21, 2019
|
ugh, this PR is so tedious.... sorry, couldn't help myself. |
rochdev
reviewed
Jun 21, 2019
rochdev
reviewed
Jun 21, 2019
rochdev
reviewed
Jun 21, 2019
rochdev
reviewed
Jun 21, 2019
rochdev
reviewed
Jun 21, 2019
rochdev
reviewed
Jun 21, 2019
rochdev
reviewed
Jun 21, 2019
rochdev
reviewed
Jun 21, 2019
Yes, this is still a work in progress. |
rochdev
reviewed
Jun 21, 2019
|
Cancelling requests behaviour changed in v6.2.0: https://github.com/tediousjs/tedious/blob/v6.2.0/src/connection.js#L1655-L1673 Tedious may or may not emit an error, depending on the state the request is currently in. I will need to look at the cancellation test a bit more carefully to handle this. |
rochdev
reviewed
Jul 2, 2019
rochdev
reviewed
Jul 2, 2019
- Need to fix context propagation on callbacks - Need to add tests testing instanceName config option, different functions that end up calling makeRequest, canceling Requests, etc.
Thanks Roch!
rishabh
force-pushed
the
rish/add-tedious-plugin
branch
from
2e6b5bb
to
c4f46fe
Compare
rochdev
requested changes
Jul 3, 2019
rochdev
reviewed
Jul 3, 2019
rochdev
reviewed
Jul 3, 2019
rochdev
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an integration for Tedious.
Motivation
We want to automatically trace the Tedious.
Plugin Checklist
Additional Notes
Cancelling requests behaviour changed in v6.2.0: https://github.com/tediousjs/tedious/blob/v6.2.0/src/connection.js#L1655-L1673
Tedious may or may not emit an error, depending on the state the request is currently in.