Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jest tests breaking because of unsupported require syntax #601

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jun 25, 2019

What does this PR do?

Update imports to not use a trailing slash.

Motivation

Jest doesn't support this syntax as reported in #585.

Additional Notes

Fixes #585

@rochdev rochdev added bug Something isn't working core labels Jun 25, 2019
@rochdev rochdev requested a review from rishabh June 25, 2019 17:20
@rochdev rochdev requested a review from a team as a code owner June 25, 2019 17:20
Copy link
Contributor

@rishabh rishabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! We should add some tests or make a PR to fix this for Jest, following your suggestion.

@rochdev
Copy link
Member Author

rochdev commented Jun 25, 2019

Opened jestjs/jest#8606 to track the issue.

@rochdev rochdev merged commit 63ca374 into master Jun 25, 2019
@rochdev rochdev deleted the fix-jest-unsupported-require branch June 25, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken under jest
2 participants