update linux prebuilds to use ubuntu 14.04 to get an older glibcxx #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update linux prebuilds to use Ubuntu 14.04 with gcc 4.7. The release scripts had to be updated since this change means a single platform is now split across multiple CircleCI jobs.
Motivation
Right now we are building on the
node:8.5.0image which uses gcc 4.9 which supports GLIBCXX 3.4.20+. Some users are not using an official Node image and may be using older operating systems with a lower version support. By using Ubuntu 14.04 with gcc 4.7 instead, we support as low as GLIBCXX 3.4.17 which is the minimum version on which Node 8 itself is able to build. Any lower version is not supported by Node 8, meaning we now have full support for any glibc version supported by Node.