fix http plugin url tag and agent requests being traced #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmustin
approved these changes
Mar 5, 2020
|
Unfortunately there is no easy way right now to test that the agent is not called in a specific test, but good point, eventually it would definitely make sense to test the default blacklist. |
bengl
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix http plugin url tag and agent requests being traced.
Motivation
A bug was reported that the requests to the trace agent were being traced. After investigating the issue, the root cause was that the URL was not formatted properly by the
httpplugin. This caused thehttp.urltag to have an incorrect value, and also caused the filter on the agent endpoint to not match the URL.The reason the tests were passing is that they were picking up the HTTP server span which had the correct tag value. This has also been fixed by disabling the server instrumentation in the client test.