-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appsec): add fingerprints #2955
Conversation
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2955 +/- ##
============================================
+ Coverage 72.46% 73.97% +1.51%
Complexity 2527 2527
============================================
Files 135 108 -27
Lines 14402 10360 -4042
Branches 991 0 -991
============================================
- Hits 10436 7664 -2772
+ Misses 3422 2696 -726
+ Partials 544 0 -544
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
45e9758
to
b51ecd6
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
0cd93ad
to
218d34b
Compare
b3e4518
to
61c0df6
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
61c0df6
to
5e0cb00
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
bcc8fb7
to
7e3a0f8
Compare
appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy
Outdated
Show resolved
Hide resolved
Nice PR @Leiyks 👏 . I didn't find anything major but I left some comments |
e0e2630
to
418effc
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
418effc
to
1a0b972
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
d3da481
to
6962115
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
6962115
to
bff8feb
Compare
appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
7b63ff8
to
f8f3c99
Compare
appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…r type Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…trieved through the correct API Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
69f4583
to
41c1773
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
41c1773
to
d9cfc57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Add support for endpoint, header, network and session fingerprints.
In order to do this, the following changes have been made:
Reviewer checklist
Related Jiras: APPSEC-55148, APPSEC-55263, APPSEC-55264,