Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsec): add fingerprints #2955

Merged
merged 16 commits into from
Nov 25, 2024
Merged

feat(appsec): add fingerprints #2955

merged 16 commits into from
Nov 25, 2024

Conversation

Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Nov 15, 2024

Description

Add support for endpoint, header, network and session fingerprints.

In order to do this, the following changes have been made:

  • Bump ruleset config from 1.10.0 to 1.13.2
  • Add unitary and integration tests to make sure fingerprint are generated and propagated for each request type
  • Clean variable names in the helper

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Related Jiras: APPSEC-55148, APPSEC-55263, APPSEC-55264,

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.97%. Comparing base (3abddef) to head (d9cfc57).
Report is 23 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2955      +/-   ##
============================================
+ Coverage     72.46%   73.97%   +1.51%     
  Complexity     2527     2527              
============================================
  Files           135      108      -27     
  Lines         14402    10360    -4042     
  Branches        991        0     -991     
============================================
- Hits          10436     7664    -2772     
+ Misses         3422     2696     -726     
+ Partials        544        0     -544     
Flag Coverage Δ
appsec-extension ?
tracer-php 73.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abddef...d9cfc57. Read the comment docs.

---- 🚨 Try these New Features:

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks changed the title feat(appsec): add fingerprint feat(appsec): add endpoint fingerprint Nov 18, 2024
@Leiyks Leiyks force-pushed the leiyks/add-fingerprinting branch 2 times, most recently from b3e4518 to 61c0df6 Compare November 18, 2024 15:33
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks marked this pull request as ready for review November 19, 2024 09:54
@Leiyks Leiyks requested a review from a team as a code owner November 19, 2024 09:54
@estringana
Copy link
Contributor

Nice PR @Leiyks 👏 . I didn't find anything major but I left some comments

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks changed the title feat(appsec): add endpoint fingerprint feat(appsec): add fingerprints Nov 20, 2024
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…r type

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…trieved through the correct API

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks/add-fingerprinting branch 3 times, most recently from 69f4583 to 41c1773 Compare November 22, 2024 14:40
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Leiyks Leiyks merged commit 1896f61 into master Nov 25, 2024
499 of 522 checks passed
@Leiyks Leiyks deleted the leiyks/add-fingerprinting branch November 25, 2024 13:58
@github-actions github-actions bot added this to the 1.6.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants