Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling) support new ZendMM api #2969

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Nov 20, 2024

Description

This PR changes the way we hook into the ZendMM starting from PHP 8.4 thanks to the new ZendMM API that got introduced in php/php-src#13432

PROF-10116

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (c1cde2d) to head (e68c066).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2969   +/-   ##
=========================================
  Coverage     74.82%   74.82%           
  Complexity     2741     2741           
=========================================
  Files           110      110           
  Lines         10863    10863           
=========================================
  Hits           8128     8128           
  Misses         2735     2735           
Flag Coverage Δ
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cde2d...e68c066. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024

Benchmarks [ profiler ]

Benchmark execution time: 2024-12-03 16:07:49

Comparing candidate commit e68c066 in PR branch florian/new-zendmm with baseline commit c1cde2d in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 8 unstable metrics.

scenario:walk_stack/1

  • 🟩 wall_time [-294.533ns; -290.630ns] or [-2.441%; -2.409%]

@realFlowControl realFlowControl force-pushed the florian/new-zendmm branch 5 times, most recently from 1ef435b to 9f23f8d Compare November 26, 2024 15:16
@realFlowControl realFlowControl marked this pull request as ready for review November 29, 2024 09:48
@realFlowControl realFlowControl requested a review from a team as a code owner November 29, 2024 09:48
@realFlowControl realFlowControl force-pushed the florian/new-zendmm branch 3 times, most recently from 146d1ec to ca68121 Compare December 2, 2024 15:47
@realFlowControl realFlowControl marked this pull request as draft December 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants