Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with newest arginfo gen_stub from PHP 8.4 #2973

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 21, 2024

Make sure things still work :-)

@bwoebi bwoebi requested a review from a team as a code owner November 21, 2024 12:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (35d1665) to head (4d07af0).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2973   +/-   ##
=========================================
  Coverage     74.82%   74.82%           
  Complexity     2741     2741           
=========================================
  Files           110      110           
  Lines         10863    10863           
=========================================
  Hits           8128     8128           
  Misses         2735     2735           
Flag Coverage Δ
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d1665...4d07af0. Read the comment docs.

---- 🚨 Try these New Features:

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-22 18:32:05

Comparing candidate commit 4d07af0 in PR branch bob/update-arginfo with baseline commit 35d1665 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

@bwoebi bwoebi force-pushed the bob/update-arginfo branch 3 times, most recently from e002b2f to 2a8ef20 Compare November 22, 2024 17:44
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit 6280989 into master Nov 23, 2024
677 of 716 checks passed
@bwoebi bwoebi deleted the bob/update-arginfo branch November 23, 2024 00:10
@github-actions github-actions bot added this to the 1.6.0 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants