Skip to content

Commit

Permalink
[SVLS-5264] fix typo and add an extra test
Browse files Browse the repository at this point in the history
  • Loading branch information
apiarian-datadog committed Sep 23, 2024
1 parent b8efbbf commit 602f569
Showing 1 changed file with 24 additions and 1 deletion.
25 changes: 24 additions & 1 deletion tests/tracer/utils_botocore/test_span_pointers.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,29 @@ class PointersCase(NamedTuple):
],
expected_warning_regex=None,
),
PointersCase(
name="s3.CopyObject with double quoted ETag",
endpoint_name="s3",
operation_name="CopyObject",
request_parameters={
"Bucket": "some-bucket",
"Key": "some-key.data",
},
response={
"CopyObjectResult": {
"ETag": '"ab12ef34"',
},
},
expected_pointers=[
_SpanPointerDescription(
pointer_kind="aws.s3.object",
pointer_direction=_SpanPointerDirection.DOWNSTREAM,
pointer_hash="e721375466d4116ab551213fdea08413",
extra_attributes={},
),
],
expected_warning_regex=None,
),
],
ids=lambda case: case.name,
)
Expand All @@ -230,7 +253,7 @@ def test_pointers(self, pointers_case: PointersCase) -> None:
mock_logger.assert_not_called()

else:
mock_logger.asser_called_once()
mock_logger.assert_called_once()

(args, kwargs) = mock_logger.call_args
assert not kwargs
Expand Down

0 comments on commit 602f569

Please sign in to comment.