Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): enable endpoint profiling using libdatadog exporter #10649

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Sep 12, 2024

Endpoint profiling allows you to scope flamegraphs by any endpoint in your service as in the screenshot. stack v2 needs more work.

Screenshot 2024-09-19 at 5 18 57 PM

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 12, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-libdatadog-endpoint-b4dd576009754cbd.yaml  @DataDog/apm-python
tests/profiling_v2/collector/test_stack.py                              @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/ddup_interface.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/libdatadog_helpers.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/sample.hpp        @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/ddup_interface.cpp    @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/sample.cpp            @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader.cpp          @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyi                       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyx                       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/test/interface.py               @DataDog/profiling-python
ddtrace/internal/processor/endpoint_call_counter.py                     @DataDog/apm-core-python
ddtrace/profiling/collector/__init__.py                                 @DataDog/profiling-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python
ddtrace/profiling/collector/stack.pyx                                   @DataDog/profiling-python
ddtrace/profiling/exporter/http.py                                      @DataDog/profiling-python
tests/profiling/collector/pprof_utils.py                                @DataDog/profiling-python
tests/profiling_v2/collector/test_asyncio.py                            @DataDog/profiling-python
tests/profiling_v2/collector/test_threading.py                          @DataDog/profiling-python
tests/tracer/test_processors.py                                         @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024

Benchmarks

Benchmark execution time: 2024-09-20 20:58:37

Comparing candidate commit b89de93 in PR branch taegyunkim/endpoint-test with baseline commit 33daba9 in branch main.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 344 metrics, 46 unstable metrics.

scenario:iast_aspects-aspect_iast_do_re_sub

  • 🟩 max_rss_usage [-2.574MB; -2.252MB] or [-8.674%; -7.590%]

scenario:iast_aspects-aspect_iast_do_tuple_string_assignment

  • 🟥 max_rss_usage [+2.426MB; +2.764MB] or [+8.921%; +10.164%]

@taegyunkim taegyunkim changed the title fix(profiling): enable endpoint profiling for default fix(profiling): enable endpoint profiling for stack v2 Sep 12, 2024
@taegyunkim taegyunkim changed the title fix(profiling): enable endpoint profiling for stack v2 fix(profiling): enable endpoint profiling for libdatadog exporter Sep 13, 2024
@taegyunkim taegyunkim marked this pull request as ready for review September 19, 2024 21:07
@taegyunkim taegyunkim requested review from a team as code owners September 19, 2024 21:07
@taegyunkim taegyunkim requested a review from a team as a code owner September 19, 2024 21:11
@taegyunkim taegyunkim added Profiling Continous Profling and removed apm:ecosystems labels Sep 19, 2024
@taegyunkim taegyunkim changed the title fix(profiling): enable endpoint profiling for libdatadog exporter fix(profiling): enable endpoint profiling using libdatadog exporter Sep 19, 2024
Copy link
Contributor Author

taegyunkim commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @taegyunkim and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly focused on the endpoint_call_counter.py file, and did a quick sweep on the profiling specific files. Will default to the profiling team to thoroughly review those!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants