Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(langchain): add support for streamed calls #10672
base: main
Are you sure you want to change the base?
feat(langchain): add support for streamed calls #10672
Changes from all commits
20cde19
57ddab0
bd80fa6
030d5c2
a250644
62b83bd
4527af7
669498a
c0ae877
cfb6a03
47e7f38
aaddc40
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added all of this logic because, unlike
model.generate
, which just takes in a list ofBaseMessage
types (ieHumanMessage
,SystemMessage
, etc.),model.stream
can take in:BaseMessage
typesPromptValue
type, which has amessages
property ofBaseMessage
typesref
Do we care about all of these different types? Or, do we just want to listify and
str
each element (this logic would also carry over to LLMObs spans, future PR)? It would make the code a lot simpler, but maybe the view of each tag not as nice.