-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracer): [SVLS-5262] AWS S3 PutObject pointer calc #10689
base: aleksandr.pasechnik/svls-5262-3-standard-hashing-function
Are you sure you want to change the base?
Conversation
|
built on top of #10687 |
Datadog ReportBranch report: ✅ 0 Failed, 3540 Passed, 2707 Skipped, 36m 35.79s Total duration (36m 55.18s time saved) |
c04dff7
to
30ed9a8
Compare
9f49dbb
to
a9746a4
Compare
BenchmarksBenchmark execution time: 2024-09-18 15:39:30 Comparing candidate commit b656061 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
@pytest.mark.parametrize( | ||
"hashing_case", | ||
[ | ||
# These test cases are copied from the dd-span-pointer-rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this comment and put a note about this in the description. And maybe make this comment a todo: instead if you'd like?
Span Pointer calculations for the AWS S3 PutObject operation. These are private functions for now.
Checklist
Reviewer Checklist