Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracer): [SVLS-5262] AWS S3 PutObject pointer calc #10689

Open
wants to merge 2 commits into
base: aleksandr.pasechnik/svls-5262-3-standard-hashing-function
Choose a base branch
from

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Sep 17, 2024

Span Pointer calculations for the AWS S3 PutObject operation. These are private functions for now.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@apiarian-datadog apiarian-datadog added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 17, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/_trace/utils_botocore/__init__.py                               @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers.py                          @DataDog/apm-sdk-api-python
tests/tracer/utils_botocore/__init__.py                                 @DataDog/apm-sdk-api-python
tests/tracer/utils_botocore/test_span_pointers.py                       @DataDog/apm-sdk-api-python

@apiarian-datadog
Copy link
Contributor Author

built on top of #10687

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 17, 2024

Datadog Report

Branch report: aleksandr.pasechnik/svls-5262-4-s3-put-object-span-pointer-calculations
Commit report: b656061
Test service: dd-trace-py

✅ 0 Failed, 3540 Passed, 2707 Skipped, 36m 35.79s Total duration (36m 55.18s time saved)

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5262-3-standard-hashing-function branch from c04dff7 to 30ed9a8 Compare September 17, 2024 18:06
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5262-4-s3-put-object-span-pointer-calculations branch from 9f49dbb to a9746a4 Compare September 17, 2024 18:06
@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2024

Benchmarks

Benchmark execution time: 2024-09-18 15:39:30

Comparing candidate commit b656061 in PR branch aleksandr.pasechnik/svls-5262-4-s3-put-object-span-pointer-calculations with baseline commit 30ed9a8 in branch aleksandr.pasechnik/svls-5262-3-standard-hashing-function.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@apiarian-datadog apiarian-datadog marked this pull request as ready for review September 17, 2024 19:04
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner September 17, 2024 19:04
@apiarian-datadog apiarian-datadog requested review from rachelyangdog and removed request for a team September 17, 2024 19:04
@pytest.mark.parametrize(
"hashing_case",
[
# These test cases are copied from the dd-span-pointer-rules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this comment and put a note about this in the description. And maybe make this comment a todo: instead if you'd like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants