Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iast): backport fix from 10706 to 2.11 #10737

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Sep 20, 2024

Description

Partial backport of the Initializer atexit fix from #10706.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux added the ASM Application Security Monitoring label Sep 20, 2024
@juanjux juanjux self-assigned this Sep 20, 2024
@juanjux juanjux requested review from a team as code owners September 20, 2024 08:34
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 20, 2024

Datadog Report

Branch report: juanjux/backport-10706-to-211
Commit report: 654a88a
Test service: dd-trace-py

✅ 0 Failed, 109912 Passed, 3979 Skipped, 5m 20.91s Total duration (32m 55.99s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Benchmark execution time: 2024-09-20 09:35:54

Comparing candidate commit 654a88a in PR branch juanjux/backport-10706-to-211 with baseline commit c0a9375 in branch 2.11.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

@juanjux juanjux enabled auto-merge (squash) September 20, 2024 13:05
@juanjux juanjux closed this Sep 20, 2024
auto-merge was automatically disabled September 20, 2024 13:14

Pull request was closed

@juanjux juanjux reopened this Sep 20, 2024
@juanjux juanjux enabled auto-merge (squash) September 20, 2024 13:19
@juanjux juanjux merged commit 44043c2 into 2.11 Sep 20, 2024
206 of 211 checks passed
@juanjux juanjux deleted the juanjux/backport-10706-to-211 branch September 20, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants