Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): missing iast microbenchmarks #10753

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Sep 23, 2024

Code security: These microbenchmarks were added previously to the code but not in the config.yaml

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Sep 23, 2024
@gnufede gnufede requested a review from a team as a code owner September 23, 2024 08:54
Copy link
Contributor

CODEOWNERS have been resolved as:

benchmarks/appsec_iast_aspects/config.yaml                              @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 23, 2024

Benchmarks

Benchmark execution time: 2024-09-24 07:06:32

Comparing candidate commit 2858e20 in PR branch gnufede/missing-microbenchmarks with baseline commit 5ce2d89 in branch main.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in candidate:

  • iast_aspects-aspect_iast_do_operator_add_inplace_params
  • iast_aspects-aspect_no_iast_do_operator_add_inplace_3_params
  • iast_aspects-aspect_no_iast_do_operator_add_inplace_params
  • iast_aspects-aspect_iast_do_operator_add_inplace_3_times
  • iast_aspects-aspect_iast_do_operator_add_inplace_3_params
  • iast_aspects-aspect_no_iast_do_operator_add_inplace_3_times

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

@avara1986 avara1986 enabled auto-merge (squash) September 24, 2024 06:26
@avara1986 avara1986 merged commit 5b81a7f into main Sep 24, 2024
553 of 554 checks passed
@avara1986 avara1986 deleted the gnufede/missing-microbenchmarks branch September 24, 2024 07:08
mabdinur pushed a commit that referenced this pull request Sep 25, 2024
Code security: These microbenchmarks were added previously to the code
but not in the config.yaml

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Alberto Vara <alberto.vara@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants