Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(requests): fix local test runs #10769

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Sep 24, 2024

Running requests tests locally results in httpbin connection errors. This regression was introduced in 72f4032#diff-9885ff9747de8410ef5d9849c7c0950e34f9a2b86bf340d5a05fa2d1514854bb. This PR ensures the service alias used in gitlab is consistent with the service name used in docker-compose. This change ensures requests tests pass both in gitlab and locally.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 24, 2024

CODEOWNERS have been resolved as:

docker-compose.yml                                                      @DataDog/apm-core-python
tests/contrib/requests/test_requests.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 24, 2024

Datadog Report

Branch report: munir/fix-requests-tests-local
Commit report: b0a2f1a
Test service: dd-trace-py

✅ 0 Failed, 642 Passed, 644 Skipped, 21m 49.44s Total duration (15m 23.59s time saved)

update docker-compose to match gitlab restrictions
@mabdinur mabdinur force-pushed the munir/fix-requests-tests-local branch from fbd5e56 to b0a2f1a Compare September 24, 2024 03:22
@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024

Benchmarks

Benchmark execution time: 2024-09-24 03:57:41

Comparing candidate commit b0a2f1a in PR branch munir/fix-requests-tests-local with baseline commit cf6f007 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant