Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add settings/config.py to core in suitespec #7071

Merged
merged 14 commits into from
Oct 2, 2023

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Sep 27, 2023

This change fixes an overlooked file inclusion in the suitespec discovered via #7060.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@emmettbutler emmettbutler requested a review from a team as a code owner September 27, 2023 16:31
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 27, 2023
@emmettbutler emmettbutler enabled auto-merge (squash) September 27, 2023 16:44
@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2023

Benchmarks

Benchmark execution time: 2023-09-29 16:30:02

Comparing candidate commit 935a70b in PR branch emmett.butler/internal-settings with baseline commit c26e86c in branch 2.x.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 89 metrics, 0 unstable metrics.

scenario:flasksimple-tracer

  • 🟩 execution_time [-318.811µs; -296.284µs] or [-5.068%; -4.710%]

@emmettbutler emmettbutler merged commit bcd04e4 into 2.x Oct 2, 2023
101 of 102 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/internal-settings branch October 2, 2023 14:03
@github-actions github-actions bot added this to the v2.1.0 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants