Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix release note for #7612 [backport 2.2] #7709

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport d5ae475 from #7706 to 2.2.

The release note in #7612 was not in the correct directory.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

The release note in #7612 was not in the correct directory.

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [x] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [x] This PR doesn't touch any of that.

(cherry picked from commit d5ae475)
@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2023

Benchmarks

Benchmark execution time: 2023-11-21 16:54:57

Comparing candidate commit 2ffa5a5 in PR branch backport-7706-to-2.2 with baseline commit 4fd3010 in branch 2.2.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 88 metrics, 0 unstable metrics.

scenario:flasksimple-appsec-telemetry

  • 🟥 max_rss_usage [+1.079MB; +1.267MB] or [+3.095%; +3.633%]

scenario:flasksimple-baseline

  • 🟥 execution_time [+96.313µs; +120.919µs] or [+2.081%; +2.612%]

@mabdinur mabdinur enabled auto-merge (squash) November 21, 2023 18:45
@mabdinur mabdinur closed this Nov 21, 2023
auto-merge was automatically disabled November 21, 2023 18:45

Pull request was closed

@mabdinur mabdinur reopened this Nov 21, 2023
@mabdinur mabdinur enabled auto-merge (squash) November 21, 2023 19:50
@mabdinur mabdinur merged commit 72e33d0 into 2.2 Nov 21, 2023
16 checks passed
@mabdinur mabdinur deleted the backport-7706-to-2.2 branch November 21, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants