Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(origin detection): implement new spec #9622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Jun 24, 2024

What does this PR do?

Implements the new Origin Detection spec.

Motivation

This is needed to improve Origin Detection with specific edges cases such as Kata Containers while also improving both backward compatibility and future-proofness.

Additional Notes

This change were already discussed internally as part of the RFC regarding New Origin Detection Spec.

Possible Drawbacks / Trade-offs

None

Describe how to test/QA your changes

Unit tests were either modified or added to reflect changes.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wdhif wdhif added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 24, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 24, 2024

Datadog Report

Branch report: CONTP-19/wassim.dhif/implement-new-origin-detection-spec
Commit report: dda2551
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 36m 34.31s Total duration (29.97s time saved)

@wdhif wdhif force-pushed the CONTP-19/wassim.dhif/implement-new-origin-detection-spec branch from 56485b2 to 811f4bf Compare July 1, 2024 10:19
@pr-commenter
Copy link

pr-commenter bot commented Jul 1, 2024

Benchmarks

Benchmark execution time: 2024-09-20 18:31:12

Comparing candidate commit dda2551 in PR branch CONTP-19/wassim.dhif/implement-new-origin-detection-spec with baseline commit 33daba9 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 355 metrics, 48 unstable metrics.

scenario:iast_aspects-aspect_iast_do_stringio_init_and_read

  • 🟥 max_rss_usage [+1.968MB; +2.310MB] or [+7.220%; +8.478%]

@github-actions github-actions bot added the stale label Aug 31, 2024
@wdhif wdhif force-pushed the CONTP-19/wassim.dhif/implement-new-origin-detection-spec branch from 811f4bf to 1b9acab Compare September 19, 2024 12:58
Copy link
Contributor

github-actions bot commented Sep 19, 2024

CODEOWNERS have been resolved as:

ddtrace/debugging/_uploader.py                                          @DataDog/debugger-python
ddtrace/internal/constants.py                                           @DataDog/apm-core-python
ddtrace/internal/processor/stats.py                                     @DataDog/apm-core-python
ddtrace/internal/remoteconfig/client.py                                 @DataDog/remote-config @DataDog/apm-core-python
ddtrace/internal/runtime/container.py                                   @DataDog/apm-core-python
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-core-python
ddtrace/internal/writer/writer.py                                       @DataDog/apm-core-python
ddtrace/profiling/exporter/http.py                                      @DataDog/profiling-python
tests/integration/test_integration.py                                   @DataDog/apm-core-python

@wdhif wdhif removed the stale label Sep 19, 2024
@wdhif wdhif marked this pull request as ready for review September 19, 2024 14:17
@wdhif wdhif requested a review from a team as a code owner September 19, 2024 14:17
@wdhif wdhif marked this pull request as draft September 19, 2024 15:40
@wdhif wdhif force-pushed the CONTP-19/wassim.dhif/implement-new-origin-detection-spec branch 5 times, most recently from c77b9ed to e1ec86a Compare September 20, 2024 14:06
Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
@wdhif wdhif force-pushed the CONTP-19/wassim.dhif/implement-new-origin-detection-spec branch from e1ec86a to dda2551 Compare September 20, 2024 17:55
@wdhif wdhif marked this pull request as ready for review September 20, 2024 20:03
@wdhif wdhif requested review from a team as code owners September 20, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant