Fix specs breaking on Ruby 2.3 due to missing String#unpack1

Sigh old rubies...
DataDog · Mar 6, 2024 · 6b3bc3f · 6b3bc3f
1 parent 66ade00
commit 6b3bc3f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -223,6 +223,10 @@ Performance/RegexpMatch:
 Performance/Sum:
   Enabled: false
 
+# Requires Ruby 2.4
+Style/UnpackFirst:
+  Enabled: false
+
 # Requires Ruby 2.5
 Style/RedundantBegin:
   Enabled: false

diff --git a/spec/datadog/profiling/spec_helper.rb b/spec/datadog/profiling/spec_helper.rb
@@ -65,7 +65,7 @@ def samples_from_pprof(pprof_data)
 
               # Tell Ruby to reinterpret the number back into uint64 little-endian bytes, and then read them again;
               # Protocol buffers always represents stuff as little-endian https://protobuf.dev/programming-guides/encoding/
-              [it.num].pack('Q<').unpack1('Q<')
+              [it.num].pack('Q<').unpack('Q<').first
             else
               it.num
             end