Skip to content

Commit

Permalink
[PROF-10198] Set service/env for GitLab runs in benchmark platform
Browse files Browse the repository at this point in the history
**What does this PR do?**

This PR sets the `DD_SERVICE` and `DD_ENV` for the gitlab benchmark in
the benchmarking platform.

**Motivation:**

While testing a few changes, I realized these benchmarks were running
with no name, thus ending up with `gitlab-runner` which is not a very
clear name (and makes it hard to know what it is).

To align with the reliability environment (`rp-ruby-gitlab`) I've
explicitly set a matching name.

**Additional Notes:**

N/A

**How to test the change?**

I've tested this with the `bp-runner`.
  • Loading branch information
ivoanjo committed Jul 23, 2024
1 parent 2505c2d commit 8d6b00a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .gitlab/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ variables:
# Benchmark's env variables. Modify to tweak benchmark parameters.
DD_TRACE_DEBUG: "false"
DD_RUNTIME_METRICS_ENABLED: "true"

DD_SERVICE: "bp-ruby-gitlab"
DD_ENV: "staging"

# Gitlab makes use of the rugged gem, which triggers the automatic no signals workaround use, see
# https://docs.datadoghq.com/profiler/profiler_troubleshooting/ruby/#unexpected-failures-or-errors-from-ruby-gems-that-use-native-extensions-in-dd-trace-rb-1110
# But in practice the endpoints we test it aren't affected, so we prefer to run the profiler in its default,
Expand Down

0 comments on commit 8d6b00a

Please sign in to comment.