Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_option method to Core::Configuration #2919

Closed
wants to merge 1 commit into from

Conversation

GustavoCaso
Copy link
Member

@GustavoCaso GustavoCaso commented Jun 20, 2023

What does this PR do?

This PR adds the default_option? to Core::Configuration

Motivation

I will port AppSec (ASM) configuration to use the one in Core::Configuration. The one key feature that the ASM configuration has that the core configuration has is the ability to check if a value has been set or if it is using the default value.

Here is the code ASM:

def default_setting?(setting)
settings.send(:default?, setting)
end

def remote_features_enabled?
Datadog::AppSec.send(:default_setting?, :ruleset)
end

Once the code is merged, we can migrate the ASM configuration to use the core configuration

Additional Notes

How to test the change?

@github-actions github-actions bot added the core Involves Datadog core libraries label Jun 20, 2023
@GustavoCaso GustavoCaso force-pushed the core-add-default_option-method branch from afd4ddf to 25fbe03 Compare June 20, 2023 16:35
@GustavoCaso GustavoCaso force-pushed the core-add-default_option-method branch from 25fbe03 to e25ee74 Compare June 20, 2023 19:29
@GustavoCaso
Copy link
Member Author

Close in favour of #2920

@GustavoCaso GustavoCaso deleted the core-add-default_option-method branch October 11, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant