Add default_option method to Core::Configuration #2919
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
default_option?
toCore::Configuration
Motivation
I will port AppSec (ASM) configuration to use the one in
Core::Configuration
. The one key feature that the ASM configuration has that the core configuration has is the ability to check if a value has been set or if it is using the default value.Here is the code ASM:
dd-trace-rb/lib/datadog/appsec/configuration.rb
Lines 88 to 90 in f7d1e5e
dd-trace-rb/lib/datadog/appsec/remote.rb
Lines 107 to 109 in cbbd749
Once the code is merged, we can migrate the ASM configuration to use the core configuration
Additional Notes
How to test the change?