Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Problem executing scripts APT::Update::Post-Invoke" issue breaking 3.1/3.2/3.3 integration apps CI #2921

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Jun 21, 2023

What does this PR do?:

This PR is a follow-up to #2917. When I started investigating the issue we saw in CI
(https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/10471/workflows/398f98c3-8d84-4d94-afff-8c92370be60d/jobs/389184):

E: Problem executing scripts APT::Update::Post-Invoke 'rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true'
E: Sub-process returned an error code

... I saw an issue locally that I fixed in #2917, but it turns out that was not the issue we were seeing.

In fact, there were two issues, but CI was failing with an earlier one, whereas I fixed the later one only (which is the only one that I saw locally).

What happened was that our CI integration apps Ruby images use the latest upstream Ruby images, and those have shifted to use the new Debian 12 "bookworm" release.

The new base OS change triggered both issues.

TL;DR the glibc version on Debian 12 triggers a bug on the docker version we were using in CI:

The fix here is simple: we were overriding the docker version used by CircleCI to use an older version of docker. I've removed the override, which will make CircleCI use the latest docker version they have available (20.10.18 as I'm writing this), which has a fix for the bug triggered by the newer glibc.

Motivation:

Fix CI.

Additional Notes:

This is one of those "a lot of time spent for a one-liner fix" PRs.

How to test the change?:

Validate that CI is green.

…ng 3.1/3.2/3.3 integration apps CI

**What does this PR do?**:

This PR is a follow-up to #2917. When I started investigating the issue
we saw in CI
(https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/10471/workflows/398f98c3-8d84-4d94-afff-8c92370be60d/jobs/389184):

```
E: Problem executing scripts APT::Update::Post-Invoke 'rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true'
E: Sub-process returned an error code
```

... I saw an issue locally that I fixed in #2917, but it turns out
that was not the issue we were seeing.

In fact, there were two issues, but CI was failing with an earlier one,
whereas I fixed the later one only (which is the only one that I saw
locally).

What happened was that our CI integration apps Ruby images
use the latest upstream Ruby images, and those have shifted to use the
new Debian 12 "bookworm" release.

The new base OS change triggered both issues.

TL;DR the glibc version on Debian 12 triggers a bug on the docker
version we were using in CI:

* https://stackoverflow.com/questions/71941032/why-i-cannot-run-apt-update-inside-a-fresh-ubuntu22-04
* https://pascalroeleven.nl/2021/09/09/ubuntu-21-10-and-fedora-35-in-docker/

The fix here is simple: we were overriding the docker version used
by CircleCI to use an older version of docker. I've removed the
override, which will make CircleCI use the latest docker version
they have available (20.10.18 as I'm writing this), which has a fix
for the bug triggered by the newer glibc.

**Motivation**:

Fix CI.

**Additional Notes**:

This is one of those "a lot of time spent for a one-liner fix" PRs.

**How to test the change?**:

Validate that CI is green.
@ivoanjo ivoanjo requested a review from a team June 21, 2023 09:28
@github-actions github-actions bot added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Jun 21, 2023
@ivoanjo ivoanjo merged commit f510352 into master Jun 21, 2023
@ivoanjo ivoanjo deleted the ivoanjo/fix-ci-docker branch June 21, 2023 10:07
@github-actions github-actions bot added this to the 1.13.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants