-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EnvironmentLogger V1 #2985
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2985 +/- ##
==========================================
- Coverage 98.08% 98.07% -0.01%
==========================================
Files 1301 1301
Lines 72104 72102 -2
Branches 3314 3314
==========================================
- Hits 70722 70716 -6
- Misses 1382 1386 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
reviewed
Jul 21, 2023
See #3020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves the EnvironmentLogger module from the Core namespace to the Tracing namespace to remove product dependencies. It also updates its specs and any references to the module.
Motivation
The overall goal of this PR is to refactor the Core namespace so that it does not depend upon product implementation. This PR specifically addresses the EnvironmentLogger module.
Additional Notes
Currently the code still couples Tracing and Profiling; however, we are hoping to remove or separate the Profiling dependency soon.
How to test the change?
This change can be tested by running unit tests for the specific file
bundle exec rspec spec/datadog/tracing/diagnostics/environment_logger_spec.rb
and by running tests for the entire suitebundle exec rake spec:main.