Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EnvironmentLogger V1 #2985

Closed
wants to merge 7 commits into from
Closed

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Jul 20, 2023

What does this PR do?
This PR moves the EnvironmentLogger module from the Core namespace to the Tracing namespace to remove product dependencies. It also updates its specs and any references to the module.

Motivation
The overall goal of this PR is to refactor the Core namespace so that it does not depend upon product implementation. This PR specifically addresses the EnvironmentLogger module.

Additional Notes
Currently the code still couples Tracing and Profiling; however, we are hoping to remove or separate the Profiling dependency soon.

How to test the change?
This change can be tested by running unit tests for the specific file bundle exec rspec spec/datadog/tracing/diagnostics/environment_logger_spec.rb and by running tests for the entire suite bundle exec rake spec:main.

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #2985 (6d0b2b7) into master (75e0942) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
- Coverage   98.08%   98.07%   -0.01%     
==========================================
  Files        1301     1301              
  Lines       72104    72102       -2     
  Branches     3314     3314              
==========================================
- Hits        70722    70716       -6     
- Misses       1382     1386       +4     
Impacted Files Coverage Δ
lib/datadog/tracing/workers/trace_writer.rb 96.25% <ø> (ø)
lib/datadog/core/configuration/components.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/component.rb 100.00% <100.00%> (ø)
.../datadog/tracing/diagnostics/environment_logger.rb 97.69% <100.00%> (ø)
spec/datadog/core/configuration/components_spec.rb 99.85% <100.00%> (ø)
...dog/tracing/diagnostics/environment_logger_spec.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/writer_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarahchen6 sarahchen6 changed the title Refactor EnvironmentLogger to remove dependencies Refactor EnvironmentLogger V1 Jul 26, 2023
@sarahchen6 sarahchen6 closed this Aug 14, 2023
@sarahchen6
Copy link
Contributor Author

See #3020

@GustavoCaso GustavoCaso deleted the environmentlogger_refactoring branch October 11, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants