Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber 8.0.0 support, test CI visibility with cucumber versions 6-8 #3061

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Adds cucumber 8.0 support

Motivation
Backporting changes from datadog-ci-rb gem: DataDog/datadog-ci-rb#7

Additional Notes
Note: protobuf issue exists in this repo but not in the datadog-ci-rb repo, so I kept protobuf gem hack here (will be removed when we migrate CI to the new gem)

How to test the change?
Appraisals are added and unit tests suit covers this change

@codecov-commenter
Copy link

Codecov Report

Merging #3061 (2987173) into master (0e7da21) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
+ Coverage   98.11%   98.13%   +0.01%     
==========================================
  Files        1328     1328              
  Lines       75076    75091      +15     
  Branches     3410     3415       +5     
==========================================
+ Hits        73662    73687      +25     
+ Misses       1414     1404      -10     
Files Changed Coverage Δ
...iling_native_extension/native_extension_helpers.rb 96.90% <100.00%> (+0.16%) ⬆️
spec/datadog/ci/contrib/cucumber/formatter_spec.rb 100.00% <100.00%> (ø)
...datadog/profiling/native_extension_helpers_spec.rb 97.85% <100.00%> (+0.04%) ⬆️
spec/datadog/profiling/spec_helper.rb 95.55% <100.00%> (+0.20%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anmarchenko anmarchenko marked this pull request as ready for review August 18, 2023 16:16
@anmarchenko anmarchenko requested a review from a team August 18, 2023 16:16
@anmarchenko anmarchenko merged commit cedb7ab into master Aug 21, 2023
163 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/cucumber8_support branch August 21, 2023 08:15
@github-actions github-actions bot added this to the 1.14.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants