Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rack 3 by adding to test matrix #3132

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 14, 2023

Motivation:

Support Rack 3

What does this PR do?

  1. Rack is tested against version 1, 2, 3
  2. Skip Rack 1.x with Ruby 3.3, because non-deprecated form of Regexp.new does not backport to Rack 1.x.
    Fix Regexp deprecated third argument with Regexp::NOENCODING rack/rack#1998

Additional notes

Appsec test requires gem 'rack-contrib' in the group.

@TonyCTHsu TonyCTHsu requested a review from a team September 14, 2023 12:36
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #3132 (c81c93b) into master (af6e416) will increase coverage by 0.00%.
Report is 12 commits behind head on master.
The diff coverage is 98.52%.

@@           Coverage Diff           @@
##           master    #3132   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files        1283     1284    +1     
  Lines       73918    73980   +62     
  Branches     3421     3425    +4     
=======================================
+ Hits        72565    72626   +61     
- Misses       1353     1354    +1     
Files Changed Coverage Δ
spec/datadog/core/environment/execution_spec.rb 95.79% <94.44%> (-0.32%) ⬇️
lib/datadog/core/environment/execution.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/contrib/rack/header_tagging.rb 100.00% <100.00%> (ø)
...atadog/tracing/contrib/rack/header_tagging_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 25, 2023 11:39
@TonyCTHsu TonyCTHsu merged commit 20c8800 into master Sep 25, 2023
176 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/rack-3-support branch September 25, 2023 18:38
@github-actions github-actions bot added this to the 1.15.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants