Add more logging to profiling flaky test #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR adds more logging to a flaky test reported by @marcotc ( https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/11866/workflows/08660eeb-0746-4675-87fd-33d473a3f479/jobs/445903 ). I'm not sure what may have caused the test to fail, so I've added a bunch of extra information so that we can look into the issue the next time it shows up. **Motivation:** Hunt down every last flaky test! **Additional Notes:** If you see any profiling flaky tests, always let me know! I'm aiming to have ZERO flaky tests, so anything you find is new to me! **How to test the change?** Change only affects tests :)
anmarchenko
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds more logging to a flaky test reported by @marcotc ( https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/11866/workflows/08660eeb-0746-4675-87fd-33d473a3f479/jobs/445903 ).
I'm not sure what may have caused the test to fail, so I've added a bunch of extra information so that we can look into the issue the next time it shows up.
Motivation:
Hunt down every last flaky test!
Additional Notes:
If you see any profiling flaky tests, always let me know! I'm aiming to have ZERO flaky tests, so anything you find is new to me!
How to test the change?
Change only affects tests :)
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.