Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten appraisal filenames with only major and minor version of Ruby #3175

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 29, 2023

What does this PR do?

Shorten the appraisal filenames with only major and minor version of Ruby, so that when we upgrade the patch version, no changes need to be made.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 29, 2023 16:41
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 29, 2023 16:41
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the nice improvement, LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #3175 (9f3839d) into master (1ef3cf5) will not change coverage.
Report is 7 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3175   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files        1247     1247           
  Lines       71703    71703           
  Branches     3338     3338           
=======================================
  Hits        70371    70371           
  Misses       1332     1332           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ivoanjo
Copy link
Member

ivoanjo commented Oct 2, 2023

@TonyCTHsu asked me to merge this in, so here it goes! :)

@ivoanjo ivoanjo merged commit 70bad1d into master Oct 2, 2023
176 checks passed
@ivoanjo ivoanjo deleted the tonycthsu/shorten-appraisl-file-name branch October 2, 2023 08:52
@github-actions github-actions bot added this to the 1.15.0 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants