Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete exception_controller option #3243

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove obsolete exception_controller option #3243

merged 1 commit into from
Dec 7, 2023

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 7, 2023 •
edited
Loading

2.0 Upgrade Guide notes

The exception_controller configuration option has been removed for Rails and Action Pack because it is automatically detected.

@TonyCTHsu TonyCTHsu self-assigned this Nov 7, 2023
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 7, 2023
@TonyCTHsu TonyCTHsu added do-not-merge/WIP Not ready for merge breaking-change Involves a breaking change labels Nov 7, 2023
@TonyCTHsu TonyCTHsu changed the base branch from master to 2.0 December 7, 2023 16:01
@TonyCTHsu TonyCTHsu marked this pull request as ready for review December 7, 2023 16:03
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner December 7, 2023 16:03
@TonyCTHsu TonyCTHsu removed the do-not-merge/WIP Not ready for merge label Dec 7, 2023
ekump
ekump approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would suggest updating the 2.0 release notes to something along the lines of

"The exception_controller configuration option has been removed for Rails and Action Pack as the controller is now automatically detected. "

@TonyCTHsu TonyCTHsu merged commit 5d2190f into 2.0 Dec 7, 2023
217 of 219 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-exception-controller-configuration branch December 7, 2023 20:58
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
This was referenced Apr 12, 2024
Closed
Closed
Merged
Merged
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@ekump ekump ekump approved these changes

Assignees

@TonyCTHsu TonyCTHsu

Labels
2.0 breaking-change Involves a breaking change integrations Involves tracing integrations tracing
Projects
None yet
Milestone
2.0.0.beta1
Development

Successfully merging this pull request may close these issues.
4 participants
@TonyCTHsu @anmarchenko @ekump @ivoanjo