Add on_error settings for mysql2
#3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekump
approved these changes
Dec 11, 2023
ekump
reviewed
Dec 11, 2023
marcotc
approved these changes
Dec 11, 2023
alai97
approved these changes
Dec 11, 2023
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Co-authored-by: Edmund Kump <edmund.kump@datadoghq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 1253 1253
Lines 72766 72781 +15
Branches 3417 3417
==========================================
+ Hits 71481 71495 +14
- Misses 1285 1286 +1 ☔ View full report in Codecov by Sentry. |
|
Wow, this is amazing @TonyCTHsu, thank you! This is exactly what we are looking for! Question: do you think this is something we can also implement for the grape integration? We have this issue currently where we catch all exceptions using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
on_errorsettings formysql2instrumentation.Motivation:
This proc provides the flexibility to handle exception that does not want to be reported.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.