Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GraphQL::Tracing::DataDogTrace when it's available #3432

Closed

Conversation

rmosolgo
Copy link

@rmosolgo rmosolgo commented Feb 2, 2024

What does this PR do?

Uses the new GraphQL-Ruby trace_with API directly, instead of via use ...., to avoid a deprecation warning.

Motivation:

Someone reported the deprecation warning to me

Additional Notes:

Although this changes how the module is applied, it doesn't actually change behavior on recent GraphQL-Ruby versions, because GraphQL-Ruby was applying this new module even when the old one was attached: https://github.com/rmosolgo/graphql-ruby/blob/1a0b0dea2f9134c63f20228001c785f9cbaea3d9/lib/graphql/tracing/platform_tracing.rb#L82-L85

So, I think users have already been using the new code.

How to test the change?

Unit tests

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@rmosolgo rmosolgo requested review from a team as code owners February 2, 2024 14:47
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Feb 2, 2024
@TonyCTHsu
Copy link
Contributor

👋 @rmosolgo , I already have this in our 2.0 release. #3417

Copy link

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for docs!

@rmosolgo
Copy link
Author

rmosolgo commented Feb 2, 2024

That looks great, @TonyCTHsu, thanks!

@rmosolgo rmosolgo closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants