Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for log correlation #3476

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Add benchmark for log correlation #3476

merged 1 commit into from
Feb 23, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Feb 22, 2024

Follow up to #3474

What does this PR do?

Adds a benchmark that measures the process of generating a log correlation information from an active trace.
This happens whenever a log line is generated in a traced application.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner February 22, 2024 23:02
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Feb 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 22, 2024

Benchmarks

Benchmark execution time: 2024-02-22 23:05:07

Comparing candidate commit 181eba4 in PR branch bm-log_correlation with baseline commit 4249600 in branch bm-digest.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 1 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (4249600) to head (181eba4).
Report is 1 commits behind head on bm-digest.

Additional details and impacted files
@@            Coverage Diff             @@
##           bm-digest    #3476   +/-   ##
==========================================
  Coverage      98.07%   98.07%           
==========================================
  Files           1235     1235           
  Lines          71980    71980           
  Branches        3393     3393           
==========================================
  Hits           70595    70595           
  Misses          1385     1385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from bm-digest to 2.0 February 23, 2024 21:43
@marcotc marcotc merged commit d24fd06 into 2.0 Feb 23, 2024
155 checks passed
@marcotc marcotc deleted the bm-log_correlation branch February 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants