Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for distributed trace propagation #3480

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add benchmark for distributed trace propagation #3480

merged 2 commits into from
Feb 27, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Feb 23, 2024

What does this PR do?

Add benchmarking for distributed trace propagation round-trip: extracting distributed headers from the active trace, then passing those headers back into a trace digest.

This PR has benchmarks for both the Datadog propagation style and W3C Trace Context style.

It also has a benchmark for a basic, digest generation and continuation.

Motivation:
This captures the complete overhead of distributed tracing.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner February 23, 2024 21:58
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Feb 23, 2024
@marcotc marcotc changed the title Add benchmark for propagation Add benchmark for distributed trace propagation Feb 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 23, 2024

Benchmarks

Benchmark execution time: 2024-02-23 22:10:58

Comparing candidate commit d3b67fc in PR branch bm-prop with baseline commit d24fd06 in branch 2.0.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (d24fd06) to head (d3b67fc).

Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3480   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files        1235     1235           
  Lines       71980    71980           
  Branches     3393     3393           
=======================================
  Hits        70595    70595           
  Misses       1385     1385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit 9cead28 into 2.0 Feb 27, 2024
154 checks passed
@marcotc marcotc deleted the bm-prop branch February 27, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants