-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add span links to the Datadog API #3546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
changed the title
feat: Add span links to Datadog API
feat: Add span links to the Datadog API
Mar 20, 2024
mabdinur
force-pushed
the
munir/add-dd-span-links
branch
2 times, most recently
from
March 21, 2024 20:45
e1346ba
to
78e19ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3546 +/- ##
========================================
Coverage 98.11% 98.11%
========================================
Files 1236 1238 +2
Lines 72179 72303 +124
Branches 3396 3408 +12
========================================
+ Hits 70815 70940 +125
+ Misses 1364 1363 -1 ☔ View full report in Codecov by Sentry. |
mabdinur
force-pushed
the
munir/add-dd-span-links
branch
from
March 21, 2024 22:12
78e19ba
to
dd0a231
Compare
mabdinur
commented
Mar 21, 2024
mabdinur
requested review from
TonyCTHsu and
marcotc
and removed request for
TonyCTHsu
March 25, 2024 15:22
marcotc
reviewed
Mar 28, 2024
marcotc
reviewed
Mar 28, 2024
marcotc
reviewed
Mar 28, 2024
marcotc
approved these changes
Apr 2, 2024
This was referenced Apr 12, 2024
This was referenced Apr 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces an API for generating and serializing span links using the Datadog API. Support for OTEL span links will be introduced in a future PR.
Inspiration: https://github.com/open-telemetry/opentelemetry-ruby/blob/b1d6d050c613ad81f51dbe6db498815deeb110d4/api/lib/opentelemetry/trace/link.rb#L13
Motivation:
Span Links provides a new mechanism to correlate spans.
Additional Notes:
datadog-agent v7.41
. datadog-agent<7.41 does not support deserializing span links.How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!