Support stats "yjit_alloc_size" #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/datadog/core/runtime/metrics.rb:143:9: C: Metrics/MethodLength: Method has too many lines. [40/36]
def flush_yjit_stats ...
^^^^^^^^^^^^^^^^^^^^
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3661 +/- ##
==========================================
- Coverage 98.10% 98.10% -0.01%
==========================================
Files 1225 1225
Lines 72522 72528 +6
Branches 3446 3448 +2
==========================================
+ Hits 71151 71154 +3
- Misses 1371 1374 +3 ☔ View full report in Codecov by Sentry. |
|
@marcotc |
* master: (34 commits) Add hanami app to integration CI configurations (DataDog#3639) Update UpgradeGuide in README.md Update lockfiles for release 2.0.0 Bump version 2.0.0.rc1 to 2.0.0 Add 2.0.0 to CHANGELOG.md Add missing Apache 2.0 license from gemspec Use ffi 1.16.3 Add platform Output gem version Output debug logs Fix spec to exclude .vscode directory Fix docker run command Add vscode settings for dockerfile file associations Update gem version Update gemfiles/* Update `ffi` in Gemfile Remove experimental warning from OpenTelemetry.md Remove latest tag on docker images add installer system tests Extract trace id format helper method (DataDog#3670) ...
p-datadog
approved these changes
Jun 10, 2024
|
@p-datadog |
marcotc
approved these changes
Jun 11, 2024
|
Thank you very much for the PR @MITSUBOSHI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation:
--yjit-exec-mem-sizeoption.Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!