Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build oci package #3662

Merged
merged 5 commits into from
May 30, 2024
Merged

Build oci package #3662

merged 5 commits into from
May 30, 2024

Conversation

randomanderson
Copy link
Contributor

What does this PR do?
Builds and publishes the OCI package for ruby

Motivation:
OCI packages are needed for the datadog install and fleet management

How to test the change?
Built packages need to be tested with internal tooling

@randomanderson randomanderson added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label May 23, 2024
@github-actions github-actions bot removed the dev/ci Involves CircleCI, GitHub Actions, or GitLab label May 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (f8144d9) to head (67bcba0).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3662   +/-   ##
=======================================
  Coverage   98.10%   98.11%           
=======================================
  Files        1232     1232           
  Lines       72560    72560           
  Branches     3447     3447           
=======================================
+ Hits        71188    71189    +1     
+ Misses       1372     1371    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randomanderson randomanderson marked this pull request as ready for review May 23, 2024 14:41
@randomanderson randomanderson requested a review from a team as a code owner May 23, 2024 14:41
@pr-commenter
Copy link

pr-commenter bot commented May 23, 2024

Benchmarks

Benchmark execution time: 2024-05-29 09:24:12

Comparing candidate commit 67bcba0 in PR branch landerson/oci-package with baseline commit f8144d9 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

BaptisteFoy
BaptisteFoy previously approved these changes May 24, 2024
@BaptisteFoy BaptisteFoy dismissed their stale review May 24, 2024 09:10

Found an error

.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Baptiste Foy <baptiste.foy@datadoghq.com>
.gitlab/build-oci-package.sh Outdated Show resolved Hide resolved
.gitlab/build-oci-package.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@BaptisteFoy BaptisteFoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, the following hardocded path prevents us from starting.

dd_lib_injection_path = "/opt/datadog/apm/library/ruby/#{ruby_api_version}"

We can replace it at the OCI packaging time with sed -i 's#/opt/datadog/apm/library/ruby/#/opt/datadog-packages/datadog-apm-library-ruby/$RUBY_PACKAGE_VERSION/#g' source/host_inject.rb.

Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, it is fine.

I submitted Request changes because we need to validate this artifact before merging.

Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is passing! 👍

@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label May 30, 2024
@TonyCTHsu TonyCTHsu merged commit 359ab9b into master May 30, 2024
186 checks passed
@TonyCTHsu TonyCTHsu deleted the landerson/oci-package branch May 30, 2024 11:45
@github-actions github-actions bot added this to the 2.0.0 milestone May 30, 2024
TonyCTHsu added a commit that referenced this pull request Jun 27, 2024
backport(OCI): Backport OCI build (#3662) in 1.x-stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants