-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build oci package #3662
Build oci package #3662
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3662 +/- ##
=======================================
Coverage 98.10% 98.11%
=======================================
Files 1232 1232
Lines 72560 72560
Branches 3447 3447
=======================================
+ Hits 71188 71189 +1
+ Misses 1372 1371 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Baptiste Foy <baptiste.foy@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, the following hardocded path prevents us from starting.
dd_lib_injection_path = "/opt/datadog/apm/library/ruby/#{ruby_api_version}" |
We can replace it at the OCI packaging time with sed -i 's#/opt/datadog/apm/library/ruby/#/opt/datadog-packages/datadog-apm-library-ruby/$RUBY_PACKAGE_VERSION/#g' source/host_inject.rb
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, it is fine.
I submitted Request changes
because we need to validate this artifact before merging.
Build oci package fixes
08cd706
to
e8c4e9a
Compare
e8c4e9a
to
67bcba0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is passing! 👍
backport(OCI): Backport OCI build (#3662) in 1.x-stable
What does this PR do?
Builds and publishes the OCI package for ruby
Motivation:
OCI packages are needed for the datadog install and fleet management
How to test the change?
Built packages need to be tested with internal tooling