Include source_code_uri in gemspec, version changelog_uri
#3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
gemspec-metadata
branch
from
b970c50
to
6e0fd55
Compare
See DataDog#3684 Co-authored-by: TonyCTHsu <tonyc.t.hsu@gmail.com>
Earlopain
force-pushed
the
gemspec-metadata
branch
from
6e0fd55
to
f55d3ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3701 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 1225 1225
Lines 72795 72802 +7
Branches 3482 3482
=======================================
+ Hits 71420 71428 +8
+ Misses 1375 1374 -1 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
Jun 12, 2024
|
Also pulled in #3697 to fix CI test failure :) |
|
Ah, oops. I missed this both here and in the other PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3684
If you compare https://rubygems.org/gems/datadog and https://rubygems.org/gems/ddtrace you will notice that
datadogis missing the GitHub star count, and the "Source Code" link. Right now you can only go to source through the "Changelog" link. This should fix that, though the GitHub badge may depend onspec.homepage, not entirely sure. Either way, a bit better than now.