feat(otel): add support for span events #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
force-pushed
the
munir/add-span-events
branch
from
be2749a
to
2e3e798
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
mabdinur
force-pushed
the
munir/add-span-events
branch
from
080e3b0
to
78f8b78
Compare
mabdinur
commented
Jul 10, 2024
mabdinur
force-pushed
the
munir/add-span-events
branch
from
589abcf
to
5beeb47
Compare
mabdinur
force-pushed
the
munir/add-span-events
branch
from
9230214
to
6d71a35
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3776 +/- ##
========================================
Coverage 97.91% 97.91%
========================================
Files 1246 1248 +2
Lines 74999 75154 +155
Branches 3627 3636 +9
========================================
+ Hits 73435 73590 +155
Misses 1564 1564 ☔ View full report in Codecov by Sentry. |
mabdinur
commented
Jul 12, 2024
mabdinur
commented
Jul 12, 2024
mabdinur
commented
Jul 12, 2024
mabdinur
commented
Jul 12, 2024
mabdinur
force-pushed
the
munir/add-span-events
branch
from
e2b667a
to
f78f874
Compare
mabdinur
commented
Jul 16, 2024
mabdinur
commented
Jul 16, 2024
mabdinur
commented
Jul 16, 2024
mabdinur
commented
Jul 16, 2024
mabdinur
changed the title
mabdinur
changed the title
mabdinur
force-pushed
the
munir/add-span-events
branch
from
bb92318
to
c1cd64f
Compare
marcotc
approved these changes
Jul 16, 2024
TonyCTHsu
reviewed
Jul 17, 2024
TonyCTHsu
reviewed
Jul 17, 2024
TonyCTHsu
reviewed
Jul 17, 2024
TonyCTHsu
approved these changes
Jul 17, 2024
p-datadog
reviewed
Jul 17, 2024
mabdinur
force-pushed
the
munir/add-span-events
branch
from
7784672
to
b6e3c5e
Compare
mabdinur
force-pushed
the
munir/add-span-events
branch
from
b6e3c5e
to
54c757e
Compare
marcotc
reviewed
Jul 17, 2024
mabdinur
force-pushed
the
munir/add-span-events
branch
2 times, most recently
from
f01655f
to
c9d6455
Compare
Library Vulnerabilities✅ No library vulnerabilities found (scanned da8c243). Code Vulnerabilities
Code Quality Violations
|
mabdinur
force-pushed
the
munir/add-span-events
branch
from
c9d6455
to
64e29a1
Compare
Code Vulnerabilities
Code Quality Violations
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Span.record_exception. This ensures the status of the underlying Datadog span is updated when an exception is recorded on an OpenTelemetry Span.Motivation:
The OpenTelemetry API supports setting Events on spans. Currently these events are ignored by the ddtrace library. To fully support the OpenTelemetry API the ddtrace library must support sending span events to the Datadog Agent.
Additional Notes:
How to test the change?
Unit tests + DataDog/system-tests#2735
Unsure? Have a question? Request a review!