Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Consider using fetch on hash key" cop #3811

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Disable "Consider using fetch on hash key" cop #3811

merged 1 commit into from
Jul 29, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jul 26, 2024

This a static analysis check that does not align with our current Rubocop cops, and goes againts the standard Ruby Hash access syntax:
Screenshot 2024-07-26 at 1 10 43 PM

@marcotc marcotc requested a review from a team as a code owner July 26, 2024 20:11
@marcotc marcotc added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Jul 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (f72d19f) to head (12c644e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3811   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files        1261     1261           
  Lines       75620    75620           
  Branches     3706     3706           
=======================================
  Hits        74036    74036           
  Misses       1584     1584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jul 26, 2024

Benchmarks

Benchmark execution time: 2024-07-26 20:39:12

Comparing candidate commit 12c644e in PR branch hash-fetch with baseline commit f72d19f in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 2 unstable metrics.

scenario:100 span trace - no writer

  • 🟩 throughput [+8.035op/s; +8.747op/s] or [+2.314%; +2.520%]

@marcotc marcotc merged commit ef6e90f into master Jul 29, 2024
181 checks passed
@marcotc marcotc deleted the hash-fetch branch July 29, 2024 16:11
@github-actions github-actions bot added this to the 2.3.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants