-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-TICKET] Don't put results in benchmarking folder directly #3833
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3833 +/- ##
=======================================
Coverage 97.86% 97.87%
=======================================
Files 1264 1264
Lines 75762 75762
Branches 3720 3720
=======================================
+ Hits 74146 74151 +5
+ Misses 1616 1611 -5 ☔ View full report in Codecov by Sentry. |
**What does this PR do?** This PR tweaks the configuration for benchmark output results to place result files in the current directory the benchmark gets executed from, instead of placing the results in the benchmarks directory. **Motivation:** In #3810 we standardized the results output file name in benchmarks to match the benchmark name. In that PR, we used `__FILE__` as a prefix. This changed where results are placed: where previously they were placed in the current folder where the benchmarks were run from (often the root of the repo), with this PR, they started getting placed in the benchmarks directory. This clashes with our `validate_benchmarks_spec.rb` that look for files in those directories, e.g. running a benchmark and then running the test suite will make the test suite fail which is somewhat annoying. While I could've changed the tests to filter out results files, I also find it useful to place the results where I'm executing the benchmarks from, as it makes organization easier (you just run the benchmark from where you want and you get the result there ). **Additional Notes:** N/A **How to test the change?** Run the benchmarks and confirm the results file gets placed in the current folder! :)
b971c15
to
5a52a42
Compare
I need to tweak our test execution harness before merging this, it's failing with
|
This is currently blocked by https://github.com/DataDog/benchmarking-platform/pull/92 |
BenchmarksBenchmark execution time: 2024-08-12 13:47:20 Comparing candidate commit 5a52a42 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler gc
scenario:stack collector
|
What does this PR do?
This PR tweaks the configuration for benchmark output results to place result files in the current directory the benchmark gets executed from, instead of placing the results in the benchmarks directory.
Motivation:
In #3810 we standardized the results output file name in benchmarks to match the benchmark name.
In that PR, we used
__FILE__
as a prefix. This changed where results are placed: where previously they were placed in the current folder where the benchmarks were run from (often the root of the repo), with this PR, they started getting placed in the benchmarks directory.This clashes with our
validate_benchmarks_spec.rb
that look for files in those directories, e.g. running a benchmark and then running the test suite will make the test suite fail which is somewhat annoying.While I could've changed the tests to filter out results files, I also find it useful to place the results where I'm executing the benchmarks from, as it makes organization easier (you just run the benchmark from where you want and you get the result there ).
Additional Notes:
N/A
How to test the change?
Run the benchmarks and confirm the results file gets placed in the current folder! :)