Add missing includes to fix build and LSP errors on Mac

[AlexJF]

What does this PR do?

• Add missing include to clock_id_noop.c.
• Move ruby.h include to clock_id.h since that file already references VALUE.

Motivation:

Fix a compilation error on mac:

❯ rake compile                     
/opt/homebrew/bin/gmake install sitearchdir=../../../../lib sitelibdir=../../../../lib target_prefix=
compiling ../../../../ext/datadog_profiling_native_extension/clock_id_from_pthread.c
compiling ../../../../ext/datadog_profiling_native_extension/clock_id_noop.c
../../../../ext/datadog_profiling_native_extension/clock_id_noop.c:14:43: error: unknown type name 'DDTRACE_UNUSED'
thread_cpu_time_id thread_cpu_time_id_for(DDTRACE_UNUSED VALUE _thread) {
                                          ^
../../../../ext/datadog_profiling_native_extension/clock_id_noop.c:14:64: error: expected ')'
thread_cpu_time_id thread_cpu_time_id_for(DDTRACE_UNUSED VALUE _thread) {
                                                               ^
../../../../ext/datadog_profiling_native_extension/clock_id_noop.c:14:42: note: to match this '('
thread_cpu_time_id thread_cpu_time_id_for(DDTRACE_UNUSED VALUE _thread) {
                                         ^
../../../../ext/datadog_profiling_native_extension/clock_id_noop.c:18:37: error: unknown type name 'DDTRACE_UNUSED'
thread_cpu_time thread_cpu_time_for(DDTRACE_UNUSED thread_cpu_time_id _time_id) {
                                    ^
../../../../ext/datadog_profiling_native_extension/clock_id_noop.c:18:71: error: expected ')'
thread_cpu_time thread_cpu_time_for(DDTRACE_UNUSED thread_cpu_time_id _time_id) {
                                                                      ^
../../../../ext/datadog_profiling_native_extension/clock_id_noop.c:18:36: note: to match this '('
thread_cpu_time thread_cpu_time_for(DDTRACE_UNUSED thread_cpu_time_id _time_id) {

This is not a problem on CI or Ivo™️ builds because they'll use clock_id_from_pthread.c, not clock_id_noop.c.

As for the ruby.h include move to the header, it's mainly to address the clang LSP diagnostic:

Builds themselves work because all current includers of clock_id.h have already included ruby.h before.

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

[ivoanjo]

👍 LGTM Thanks for keeping our 🍎s in working order :)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (93a2891) to head (27acb52).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3843      +/-   ##
==========================================
- Coverage   97.84%   97.84%   -0.01%     
==========================================
  Files        1264     1264              
  Lines       75737    75737              
  Branches     3729     3729              
==========================================
- Hits        74108    74102       -6     
- Misses       1629     1635       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-08-14 10:30:03

Comparing candidate commit 27acb52 in PR branch alexjf/fix-prof-build-mac with baseline commit 93a2891 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

• 🟥 throughput [-0.753op/s; -0.731op/s] or [-10.291%; -9.991%]