Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default AppSec obfuscation regex #3857

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

y9v
Copy link
Member

@y9v y9v commented Aug 21, 2024

What does this PR do?
This PR updates default obfuscation regexps for AppSec.

Motivation:
RFC "AppSec Events - Sensitive Data Obfuscation"

Additional Notes:
None

How to test the change?
Send AppSec events in a local environment with key/value that has to be obfuscated.

@y9v y9v self-assigned this Aug 21, 2024
@y9v y9v requested a review from a team as a code owner August 21, 2024 13:36
@github-actions github-actions bot added the appsec Application Security monitoring product label Aug 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (84e92fa) to head (01ef179).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3857      +/-   ##
==========================================
- Coverage   97.86%   97.84%   -0.03%     
==========================================
  Files        1271     1271              
  Lines       75975    75975              
  Branches     3739     3739              
==========================================
- Hits        74352    74336      -16     
- Misses       1623     1639      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 21, 2024

Benchmarks

Benchmark execution time: 2024-08-21 14:09:33

Comparing candidate commit 01ef179 in PR branch update-default-appsec-obfuscation-regex with baseline commit 84e92fa in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@y9v y9v merged commit e31c2a5 into master Aug 23, 2024
186 checks passed
@y9v y9v deleted the update-default-appsec-obfuscation-regex branch August 23, 2024 08:41
@github-actions github-actions bot added this to the 2.4.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants