DEBUG-2334 Move tracing rate limiters to Core #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
force-pushed
the
move-rate-limiter
branch
from
69b6152
to
e04e6d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3870 +/- ##
========================================
Coverage 97.85% 97.85%
========================================
Files 1271 1277 +6
Lines 76024 76302 +278
Branches 3740 3740
========================================
+ Hits 74395 74669 +274
- Misses 1629 1633 +4 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-08-28 14:23:00 Comparing candidate commit a3162cb in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler - profiler gc
scenario:profiler - sample timeline=false
|
Dynamic instrumentation will use the TokenBucket rate limiter. To facilitate this, the basic rate limiters are being moved from tracing to core.
p-datadog
force-pushed
the
move-rate-limiter
branch
from
e04e6d6
to
a3162cb
Compare
TonyCTHsu
approved these changes
Aug 30, 2024
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Sep 3, 2024
* master: (56 commits) DEBUG-2334 Move tracing rate limiters to Core (DataDog#3870) Fix permissions system-tests workflow Fix update-gemfiles workflow permissions Expand stripe matrix Update gemfiles/* Remove comments Refactor spec Change path matching with gem root Remove `debug` level Improve regex Add stack_trace fields Fix constant reference Lazy load default waf processers and scanners in order to load telemetry logs Telemetry log for processor and rule_loader [NO-TICKET] Fix stale apt cache in memory leaks CI test [NO-TICKET] Add more memory leak testing for profiling using asan Fix profiler not picking up VM compilation settings correctly Lint Fix failing specs Remove obsolete http route spec ...
y9v
pushed a commit
that referenced
this pull request
Sep 13, 2024
Dynamic instrumentation will use the TokenBucket rate limiter. To facilitate this, the basic rate limiters are being moved from tracing to core. Co-authored-by: Oleg Pudeyev <code@olegp.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic instrumentation will use the TokenBucket
rate limiter. To facilitate this, the basic rate limiters are being moved from tracing to core.
Additional Notes:
There are no functionality changes in this PR. All code got deindented one level and the namespace was edited in references to match the new location.
How to test the change?
Existing unit tests
Unsure? Have a question? Request a review!