Telemetry logs for AppSec #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-08-29 08:58:16 Comparing candidate commit 4aec627 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
y9v
approved these changes
Aug 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3873 +/- ##
========================================
Coverage 97.85% 97.86%
========================================
Files 1271 1277 +6
Lines 76024 76364 +340
Branches 3740 3740
========================================
+ Hits 74395 74731 +336
- Misses 1629 1633 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send telemetry logs about AppSec errors. The errors are mostly related to load waf rules and related data.
I refactor constant
DEFAULT_WAF_PROCESSORSandDEFAULT_WAF_SCANNERSto methods with instance variable cache in order to avoid eager loading before telemetry component becomes ready during the components initialization lifecycle.