Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand stripe matrix #3875

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Expand stripe matrix #3875

merged 1 commit into from
Aug 30, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Expand stripe test matrix.

Our stripe instrumentation is very stable, and I am using it as a demonstration for improving coverage.

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner August 29, 2024 21:17
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Aug 29, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2024

Benchmarks

Benchmark execution time: 2024-08-29 21:38:04

Comparing candidate commit 17a0d4f in PR branch tonycthsu/stripe-matrix with baseline commit 18dafe3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu merged commit 72f2d40 into master Aug 30, 2024
189 of 191 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/stripe-matrix branch August 30, 2024 07:09
@github-actions github-actions bot added this to the 2.4.0 milestone Aug 30, 2024
@@ -202,17 +202,13 @@ TRACER_VERSIONS = [
'3.2',
'3.3',
'3.4',
# ADD NEW RUBIES HERE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is important! We've spread these notes in our codebase to mark all places that need to be updated when a new Ruby comes out. I do think it's important to leave it :/

Copy link
Contributor Author

@TonyCTHsu TonyCTHsu Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants